Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.compile] remove compilation_context and simplify code #10838

Merged
merged 7 commits into from
Dec 3, 2024
Merged

[torch.compile] remove compilation_context and simplify code #10838

merged 7 commits into from
Dec 3, 2024

Conversation

youkaichao
Copy link
Member

remove the confusing compilation context, figure out cudagraph batchsizes during initialization of the config.

@youkaichao
commit
b67c1f6 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
commit
08e5e51 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
move func to vllm config
3ff3eb4 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
enc dec
4dc2e7a 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
draft
a5b0296 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
fix tests
8b145d3 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
update
af2e5f0 
Signed-off-by: youkaichao <[email protected]>
WoosukKwon
WoosukKwon approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@youkaichao youkaichao enabled auto-merge (squash) December 3, 2024 03:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 3, 2024
@youkaichao youkaichao merged commit dc5ce86 into vllm-project:main Dec 3, 2024
64 of 66 checks passed
@youkaichao youkaichao deleted the cudagraph_size_during_init branch December 3, 2024 07:46
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@youkaichao
[torch.compile] remove compilation_context and simplify code (vllm-pr…
3257258 
…oject#10838)

Signed-off-by: youkaichao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic robertgshaw2-neuralmagic is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @WoosukKwon